Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8223482: Unsupported ciphersuites may be offered by a TLS client #566

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

8223482: Unsupported ciphersuites may be offered by a TLS client #566

wants to merge 1 commit into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 22, 2024 •
edited by openjdk bot
Loading

Hi all,
This PR is backport of JDK-8223482, backport parity with 8u261 and emb-8u261.

The change of JDK-8223482 of two filessrc/java.base/share/classes/sun/security/ssl/SSLCipher.java and src/java.base/share/classes/sun/security/ssl/SSLContextImpl.java has already in jdk8u-dev, make this backport clean.
The file test/jdk/sun/security/pkcs11/fips/TestTLS12.java is backported cleanly.

The test test/jdk/sun/security/pkcs11/fips/TestTLS12.java run failed before this PR, run passed after this PR.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8223482 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8223482: Unsupported ciphersuites may be offered by a TLS client (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/566/head:pull/566
$ git checkout pull/566

Update a local copy of the PR:
$ git checkout pull/566
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/566/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 566

View PR using the GUI difftool:
$ git pr show -t 566

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/566.diff

@sendaoYan sendaoYan marked this pull request as draft August 22, 2024 07:45
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 78e47c6fffa26cda0ea6044342d98d423bd2a6ff 8223482: Unsupported ciphersuites may be offered by a TLS client Aug 22, 2024
@openjdk
Copy link

openjdk bot commented Aug 22, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 22, 2024
@sendaoYan sendaoYan closed this Aug 22, 2024
@sendaoYan sendaoYan deleted the jbs8223482 branch August 22, 2024 08:17
@sendaoYan sendaoYan restored the jbs8223482 branch August 22, 2024 08:56
@sendaoYan sendaoYan reopened this Aug 22, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2024

@sendaoYan This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

wait

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sendaoYan @martinuy